Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping pong with error #260

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Ping pong with error #260

merged 2 commits into from
Aug 28, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 25, 2020

Resolves #255

Add tests for unhappy path

@alpe alpe force-pushed the ping_pong_with_error branch from d9d8b4a to 11af09e Compare August 25, 2020 09:02
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #260 into stargate_ibc_eval will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           stargate_ibc_eval     #260      +/-   ##
=====================================================
+ Coverage              17.43%   17.47%   +0.03%     
=====================================================
  Files                     36       36              
  Lines                  11516    11516              
=====================================================
+ Hits                    2008     2012       +4     
+ Misses                  9406     9404       -2     
+ Partials                 102      100       -2     
Impacted Files Coverage Δ
x/wasm/ibc.go 66.66% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab1a02...cf23dfe. Read the comment docs.

@alpe alpe changed the base branch from alex_ibc_spike2d to stargate_ibc_eval August 25, 2020 10:24
@alpe alpe force-pushed the ping_pong_with_error branch from 11af09e to cf23dfe Compare August 25, 2020 10:26
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test cases, but some comments on where the packet/ack come from?

x/wasm/relay_pingpong_test.go Show resolved Hide resolved
x/wasm/relay_pingpong_test.go Show resolved Hide resolved
@ethanfrey ethanfrey merged commit f6d92b7 into stargate_ibc_eval Aug 28, 2020
@ethanfrey ethanfrey deleted the ping_pong_with_error branch August 28, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants